feat: introduce disableAnimations option for screenshots#11870
Merged
aslushnikov merged 4 commits intoFeb 9, 2022
Conversation
aslushnikov
changed the title
stopCSSAnimations optionstopCSSAnimations option for screenshots
aslushnikov
changed the title
stopCSSAnimations option for screenshotsdisableAnimations option for screenshots
dgozman
reviewed
Feb 7, 2022
| When true, takes a screenshot of the full scrollable page, instead of the currently visible viewport. Defaults to | ||
| `false`. | ||
|
|
||
| ### option: Page.screenshot.disableAnimations |
Collaborator
There was a problem hiding this comment.
Let's follow up with moving screenshot options to params.md?
2 tasks
p01
reviewed
Feb 9, 2022
p01
reviewed
Feb 9, 2022
This option stops all kinds of CSS animations while doing screenshot: - CSS animations - CSS transitions - Web Animations Animations get different treatment depending on animation duration: - finite animations are fast-forwarded to its end, issuing the `transitionend` event. - Infinite animations are resetted to its beginning, and then resumed after the screenshot. References microsoft#9938
aslushnikov
force-pushed
the
stop-css-animations-option
branch
from
33b0980 to
3397abf
Compare
dgozman
approved these changes
Feb 9, 2022
|
hey, did this get reverted or something? can't find find option in the current code / release. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option stops all kinds of CSS animations while doing screenshot:
Animations get different treatment depending on animation duration:
transitionendevent.resumed after the screenshot.
References #9938, fixes #11912