chore: best-effort cleanup for output folders that are mounted#12300
Merged
aslushnikov merged 6 commits intoFeb 23, 2022
Merged
Conversation
aslushnikov
force-pushed
the
cleanup-output-folders-that-are-mounted-to-container
branch
from
b9edcbd to
5f028c3
Compare
aslushnikov
force-pushed
the
cleanup-output-folders-that-are-mounted-to-container
branch
from
77c95b9 to
1a44ad2
Compare
aslushnikov
commented
Feb 23, 2022
| removeFolder(dir, { maxBusyTries: 10 }, error => { | ||
| fulfill(error ?? undefined); | ||
| removeFolder(dir, { maxBusyTries: 10 }, async error => { | ||
| if (!error) { |
Contributor
Author
There was a problem hiding this comment.
let's check for error?.code === 'EBUSY'
dgozman
approved these changes
Feb 23, 2022
dgozman
approved these changes
Feb 23, 2022
aslushnikov
deleted the
cleanup-output-folders-that-are-mounted-to-container
branch
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Feb 23, 2022
…olders that are mounted Fixes microsoft#12106
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Feb 23, 2022
microsoft#12300)" This reverts commit e5c9d1e. Reason for revert: turns out this fix results in a 5-second delay when starting tests in docker, with `test-results` folder being a non-removable mount. The reason for the delay is the `maxBusyTries` option that we supply by default to rimraf when trying to remove the folder. While this option might come handy when removing temporary browser profile folder, it doesn't serve us well in this particular usecase.
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Feb 23, 2022
…output folders that are mounted (microsoft#12318)" This reverts commit 0a1c1da. Reason for revert: turns out this fix results in a 5-second delay when starting tests in docker, with `test-results` folder being a non-removable mount. The reason for the delay is the `maxBusyTries` option that we supply by default to rimraf when trying to remove the folder. While this option might come handy when removing temporary browser profile folder, it doesn't serve us well in this particular usecase. References microsoft#12106
aslushnikov
added a commit
that referenced
this pull request
Feb 23, 2022
#12300)" (#12321) This reverts commit e5c9d1e. Reason for revert: turns out this fix results in a 5-second delay when starting tests in docker, with `test-results` folder being a non-removable mount. The reason for the delay is the `maxBusyTries` option that we supply by default to rimraf when trying to remove the folder. While this option might come handy when removing temporary browser profile folder, it doesn't serve us well in this particular usecase. References #12106
aslushnikov
added a commit
that referenced
this pull request
Feb 23, 2022
…lders that are mounted (#12318)" (#12322) This reverts commit 0a1c1da. Reason for revert: turns out this fix results in a 5-second delay when starting tests in docker, with `test-results` folder being a non-removable mount. The reason for the delay is the `maxBusyTries` option that we supply by default to rimraf when trying to remove the folder. While this option might come handy when removing temporary browser profile folder, it doesn't serve us well in this particular usecase. References #12106
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Feb 23, 2022
- Previous attempt: microsoft#12300 - Revert with reasoning: ebc52d1 Fixes microsoft#12106
aslushnikov
added a commit
that referenced
this pull request
Feb 23, 2022
- Previous attempt: #12300 - Revert with reasoning: aslushnikov@ebc52d1 Fixes #12106
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Feb 23, 2022
… output directories SHA: 71edad3 - Previous attempt: microsoft#12300 - Revert with reasoning: ebc52d1 Fixes microsoft#12106
aslushnikov
added a commit
that referenced
this pull request
Feb 23, 2022
…irectories (#12324) SHA: 71edad3 - Previous attempt: #12300 - Revert with reasoning: aslushnikov@ebc52d1 Fixes #12106
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12106