Skip to content

tests: Enable "SharedArrayBuffer should work @smoke"#13976

Closed
Meir017 wants to merge 1 commit into
microsoft:mainfrom
Meir017:patch-2
Closed

tests: Enable "SharedArrayBuffer should work @smoke"#13976
Meir017 wants to merge 1 commit into
microsoft:mainfrom
Meir017:patch-2

Conversation

@Meir017
Copy link
Copy Markdown
Contributor

@Meir017 Meir017 commented May 5, 2022

@Meir017
Copy link
Copy Markdown
Contributor Author

Meir017 commented May 5, 2022

test is still failing, maybe this was not fixed yet 🤔
image
https://github.com/microsoft/playwright/runs/6311922527?check_suite_focus=true

@mxschmitt
Copy link
Copy Markdown
Contributor

Hi, let's file an issue for it first so we can track it as a feature request? Then we can mark it as a specific version and dig into the cause why its not working on WebKit.

@yury-s
Copy link
Copy Markdown
Member

yury-s commented May 9, 2022

test is still failing, maybe this was not fixed yet 🤔

It might have been disabled by a build flag somewhere.

@yury-s
Copy link
Copy Markdown
Member

yury-s commented May 9, 2022

I debugged it a bit and believe it's because we disabled COOP handling in #9185 as it broke some fundamental functionality at that point. We can try reebling it and see if the tests pass.

@yury-s
Copy link
Copy Markdown
Member

yury-s commented May 9, 2022

I any case SharedArrayBuffer only works when WebAssembly is supported and it is currently not on Windows so the test is going to fail on windows.

@yury-s
Copy link
Copy Markdown
Member

yury-s commented May 9, 2022

Filed #14043

@mxschmitt
Copy link
Copy Markdown
Contributor

Lets follow-up in #14043 for now to keep track of that feature request, closing for now.

@mxschmitt mxschmitt closed this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants