fix(test runner): ignore undefined values in fixtures definitions#15119
Merged
Conversation
These mean "I don't want to specify this fixture/option" instead of "I want the value of undefined". We already do similar things in the config.
yury-s
reviewed
Jun 25, 2022
yury-s
approved these changes
Jun 27, 2022
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Jul 27, 2022
…ions (microsoft#15119)" This reverts commit d7b63fa.
dgozman
added a commit
that referenced
this pull request
Jul 27, 2022
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Jul 27, 2022
…ned values in fixtures definit…ions (microsoft#15119)" Revert commit d7b63fa. Add a test for the broken behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These mean "I don't want to specify this fixture/option" instead of "I want the value of undefined", aligned with how TypeScript works. We already do similar things in the config.
Fixes #14989.