fix(fixtures): make undefined option mean "default value"#16026
Merged
Conversation
In the following example, `locale` inside the `describe`
would be reverted to the default value:
```js
test.use({ locale: 'en-GB' });
test.decsribe(() => {
test.use({ locale: undefined });
});
```
yury-s
approved these changes
Jul 28, 2022
|
|
||
| // Overriding option with "undefined" value means setting it to the default value | ||
| // from the original declaration of the option. | ||
| if (fn === undefined && options.option && previous) { |
Member
There was a problem hiding this comment.
fn is a bit weird in this context, consider a more descriptive name valueOrFn maybe?
mxschmitt
pushed a commit
to mxschmitt/playwright
that referenced
this pull request
Aug 9, 2022
…16026) In the following example, `locale` inside the `describe` would be reverted to the default value: ```js test.use({ locale: 'en-GB' }); test.decsribe(() => { test.use({ locale: undefined }); }); ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the following example,
localeinside thedescribewould be reverted to the default value:Fixes #14989.