chore: revert toHaveAttribute type sig and overloads#17406
Merged
Conversation
Revert "docs(python): add missing NotToHaveAttribute overloads (microsoft#17371)" This reverts commit 2e1ea29. Revert "docs(release-notes): add 1.26 release notes for language ports (microsoft#17345)" This reverts commit 4b8a85e. Revert "test: unflake "should support boolean attribute with options" (microsoft#17024)" This reverts commit 1dc05bd. Revert "fix: support toHaveAttribute(name, options) (microsoft#16941)" This reverts commit f30ac1d. Revert "feat: expect(locator).toHaveAttribute to assert attribute presence (microsoft#16767)" This reverts commit 622c73c.
rwoll
commented
Sep 16, 2022
Comment on lines
-7
to
-20
| ## Version 1.26 | ||
|
|
||
| ### Assertions | ||
|
|
||
| - [`method: LocatorAssertions.toHaveAttribute#2`] can now be used for asserting attribute existence. | ||
| - New option `enabled` for [`method: LocatorAssertions.toBeEnabled`]. | ||
| - [`method: LocatorAssertions.toHaveText`] now pierces open shadow roots. | ||
| - New option `editable` for [`method: LocatorAssertions.toBeEditable`]. | ||
| - New option `visible` for [`method: LocatorAssertions.toBeVisible`]. | ||
|
|
||
| ### Other highlights | ||
|
|
||
| - New option `max_redirects` for [`method: APIRequestContext.get`] and others to limit redirect count. | ||
| - Python 3.11 is now supported. |
Member
Author
There was a problem hiding this comment.
We'll bring back the release notes cleanly post cherry-pick closer to actual release. Some release notes got reverted since they were changed in 4b8a85e which also coupled a change to code. To get a clean, conflict free revert just included the whole commit.
yury-s
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "docs(python): add missing NotToHaveAttribute overloads (#17371)"
This reverts commit 2e1ea29.
Revert "docs(release-notes): add 1.26 release notes for language ports (#17345)"
This reverts commit 4b8a85e.
Revert "test: unflake "should support boolean attribute with options" (#17024)"
This reverts commit 1dc05bd.
Revert "fix: support toHaveAttribute(name, options) (#16941)"
This reverts commit f30ac1d.
Revert "feat: expect(locator).toHaveAttribute to assert attribute presence (#16767)"
This reverts commit 622c73c.