Skip to content

fix(driver): with CWD which contained spaces #17579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 2 commits into from
Sep 26, 2022
Merged

fix(driver): with CWD which contained spaces #17579

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d469df9
fix(driver): with CWD which contained spaces
mxschmitt Sep 26, 2022
877e038
Update run-driver-win.cmd
mxschmitt Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions utils/build/run-driver-win.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
@ECHO OFF
SETLOCAL
IF %PLAYWRIGHT_NODEJS_PATH%x == x SET PLAYWRIGHT_NODEJS_PATH="%~dp0\node.exe"
"%PLAYWRIGHT_NODEJS_PATH%" "%~dp0\package\lib\cli\cli.js" %*
@echo off
setlocal
if not defined PLAYWRIGHT_NODEJS_PATH (
Copy link
Copy Markdown
Member

@yury-s yury-s Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use all CAPITAL letters for the keywords?

Copy link
Copy Markdown
Contributor Author

@mxschmitt mxschmitt Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

microsoft does use lowercase in the docs, so it seems better like that: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/if

set PLAYWRIGHT_NODEJS_PATH=%~dp0\node.exe
)
"""%PLAYWRIGHT_NODEJS_PATH%""" "%~dp0\package\lib\cli\cli.js" %*