Skip to content

cherry-pick(#17879): test: rebaseline requestStorageAccess test for firefox-beta #17884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgozman merged 1 commit into from
Oct 6, 2022
Merged

cherry-pick(#17879): test: rebaseline requestStorageAccess test for firefox-beta #17884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/library/browsercontext-cookies.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,9 +350,11 @@ it('should be able to send third party cookies via an iframe', async ({ browser,
}
});

it('should support requestStorageAccess', async ({ page, server, browserName, isMac, isLinux, isWindows }) => {
it('should support requestStorageAccess', async ({ page, server, channel, browserName, isMac, isLinux, isWindows }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/17285' });
it.skip(browserName === 'chromium', 'requestStorageAccess API is not available in Chromium');
it.fixme(channel === 'firefox-beta', 'hasStorageAccess returns true, but no cookie is sent');

server.setRoute('/set-cookie.html', (req, res) => {
res.setHeader('Set-Cookie', 'name=value; Path=/');
res.end();
Expand All @@ -372,7 +374,6 @@ it('should support requestStorageAccess', async ({ page, server, browserName, is
]);
expect(serverRequest.headers.cookie).toBe('name=value');
}
return;
} else {
if (isLinux && browserName === 'webkit')
expect(await frame.evaluate(() => document.hasStorageAccess())).toBeTruthy();
Expand Down