Skip to content

chery-pick(#17918): docs: AriaRole is enum #17921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 1 commit into from
Oct 8, 2022
Merged

chery-pick(#17918): docs: AriaRole is enum #17921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/src/release-notes-java.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ page.getByLabel("User Name").fill("John");

page.getByLabel("Password").fill("secret-password");

page.getByRole("button", new Page.GetByRoleOptions().setName("Sign in")).click();
page.getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setName("Sign in")).click();

assertThat(page.getByText("Welcome, John!")).isVisible();
```
Expand All @@ -37,7 +37,7 @@ All the same methods are also available on [Locator], [FrameLocator] and [Frame]
- [`method: LocatorAssertions.toHaveAttribute`] with an empty value does not match missing attribute anymore. For example, the following snippet will succeed when `button` **does not** have a `disabled` attribute.

```js
assertThat(page.getByRole("button")).hasAttribute("disabled", "");
assertThat(page.getByRole(AriaRole.BUTTON)).hasAttribute("disabled", "");
```

### Browser Versions
Expand Down