fix(generator): .NET getByRole w/ name#18060
Merged
Merged
Conversation
mxschmitt
force-pushed
the
fix-dotnet-role-gen
branch
from
7c73652 to
39cb2d7
Compare
mxschmitt
force-pushed
the
fix-dotnet-role-gen
branch
from
39cb2d7 to
72345c7
Compare
yury-s
approved these changes
Oct 13, 2022
mxschmitt
pushed a commit
that referenced
this pull request
Oct 13, 2022
This PR cherry-picks the following commits: - a60073d Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://github.com/microsoft/playwright-dotnet/blob/607cc1f260310006ddf74e8f923a70f3b88b4b26/src/Playwright/API/Generated/Options/LocatorGetByRoleOptions.cs#L36-L52
Fixes #17960
Fixes microsoft/playwright-dotnet#2345
drive-by: new () -> new() since its the style-guide.