fix(driver): AttributeError error when CWD contains space#19801
Merged
mxschmitt merged 1 commit intoJan 2, 2023
Conversation
Member
|
Could you explain what you are trying to fix? It is unlikely that this file is used in your scenario. |
mxschmitt
approved these changes
Jan 2, 2023
Contributor
mxschmitt
left a comment
mxschmitt
left a comment
There was a problem hiding this comment.
LGTM, was able to reproduce and it works for me.
This was referenced Jan 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Playwright (1.29.0, Python 3.10.2 on Windows 11) from a path containing spaces, for example
C:\Program Files (x86)\My App Name With Spaces\, gives the following error message:This PR is based on the fix suggested by @funnydevdotvn.
In the
[...]Lib\site-packages\playwright\driver\playwright.cmdfile,%~dp0\node.exemust be in quotes to handle spaces properly.Because the
playwright.cmdfile is generated fromutils\build\run-driver-win.cmd, you'll find the change there.This improves the solution from related PR #17579.