Skip to content

fix(webkit): reenable CrossOriginOpenerPolicy#31765

Merged
yury-s merged 4 commits into
microsoft:mainfrom
yury-s:coop-navigation
Jul 23, 2024
Merged

fix(webkit): reenable CrossOriginOpenerPolicy#31765
yury-s merged 4 commits into
microsoft:mainfrom
yury-s:coop-navigation

Conversation

@yury-s
Copy link
Copy Markdown
Member

@yury-s yury-s commented Jul 19, 2024

@yury-s yury-s requested review from dgozman and mxschmitt July 19, 2024 06:30
@yury-s yury-s force-pushed the coop-navigation branch from 45c551f to 801d5d2 Compare July 19, 2024 06:31
@github-actions

This comment has been minimized.

Comment thread packages/playwright-core/src/server/webkit/wkProvisionalPage.ts Outdated
Comment thread packages/playwright-core/src/server/webkit/wkPage.ts Outdated
Comment thread packages/playwright-core/src/server/webkit/wkPage.ts Outdated
@yury-s yury-s force-pushed the coop-navigation branch from 8893967 to fdfccc7 Compare July 19, 2024 22:42
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Comment thread packages/playwright-core/src/server/webkit/wkProvisionalPage.ts
@yury-s yury-s force-pushed the coop-navigation branch from 072e4dd to 3f3a440 Compare July 23, 2024 20:24
@yury-s yury-s added CQ1 and removed CQ1 labels Jul 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

10 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/trace-viewer.spec.ts:246:1 › should have network requests
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/page-clock.spec.ts:343:3 › popup › should not run time before popup on pause
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:223:5 › should queue watches

29053 passed, 688 skipped
✔️✔️✔️

Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests others"

2 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture

17703 passed, 478 skipped
✔️✔️✔️

Merge workflow run.

@github-actions

This comment has been minimized.

@yury-s yury-s merged commit 1918ae5 into microsoft:main Jul 23, 2024
@yury-s yury-s deleted the coop-navigation branch July 23, 2024 22:02
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 2"

4 fatal errors, not part of any test
13 failed
❌ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should consume contextmenu events, despite a custom context menu
❌ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should consume contextmenu events, despite a custom context menu
❌ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should consume contextmenu events, despite a custom context menu
❌ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should consume contextmenu events, despite a custom context menu
❌ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should consume contextmenu events, despite a custom context menu
❌ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should consume contextmenu events, despite a custom context menu
❌ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should consume contextmenu events, despite a custom context menu
❌ [chromium-library] › library/browsertype-connect.spec.ts:642:5 › run-server › should fulfill with global fetch result
❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should consume contextmenu events, despite a custom context menu
❌ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should consume contextmenu events, despite a custom context menu
❌ [webkit-library] › library/capabilities.spec.ts:22:3 › SharedArrayBuffer should work @smoke

113 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-page] › page/page-click.spec.ts:230:3 › should click on checkbox input and toggle
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/capabilities.spec.ts:259:3 › requestFullscreen
⚠️ [firefox-library] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-page] › page/elementhandle-scroll-into-view.spec.ts:103:3 › should wait for element to stop moving
⚠️ [firefox-page] › page/page-click.spec.ts:230:3 › should click on checkbox input and toggle
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:142:3 › should keep selection in multiple pages
⚠️ [firefox-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
⚠️ [firefox-library] › library/capabilities.spec.ts:179:3 › should set CloseEvent.wasClean to false when the server terminates a WebSocket connection
⚠️ [firefox-library] › library/har.spec.ts:554:3 › should have popup requests
⚠️ [firefox-library] › library/tracing.spec.ts:292:5 › should overwrite existing file
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-page] › page/page-click-timeout-1.spec.ts:30:3 › should timeout waiting for button to be enabled
⚠️ [firefox-page] › page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target
⚠️ [firefox-page] › page/page-click.spec.ts:97:3 › should click the 1x1 div
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/tracing.spec.ts:412:14 › should produce screencast frames scale
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:411:5 › launchServer › should respect selectors
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:29:5 › launch server › should work with host
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:107:3 › should accept objects as options
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context
⚠️ [chromium-library] › library/chromium/tracing.spec.ts:21:3 › should output a trace
⚠️ [chromium-library] › library/har.spec.ts:82:3 › should have pages in persistent context
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:669:7 › cli codegen › should assert navigation
⚠️ [chromium-page] › page/page-mouse.spec.ts:176:3 › should trigger hover state on disabled button
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-page] › page/page-wait-for-navigation.spec.ts:63:3 › should work with commit
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-page] › page/page-set-input-files.spec.ts:40:3 › should upload a folder
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/screenshot.spec.ts:75:14 › page screenshot › should work with device scale factor
⚠️ [webkit-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:521:7 › cli codegen › should uncheck
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:86:1 › should reset serviceworker that hangs in importScripts
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:791:7 › cli codegen › should click button with nested div
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:159:7 › cli codegen › should work with TrustedTypes
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:341:7 › cli codegen › should press
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:706:7 › cli codegen › should ignore AltGraph
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:663:7 › cli codegen › should assert value on disabled input
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:688:7 › cli codegen › should assert value on disabled select
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture

217194 passed, 9479 skipped, 2795 did not run
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] SharedArrayBuffer should work in WebKit

2 participants