Skip to content

chore(doclint): handle hidden metadata earlier in parsing#38926

Merged
Skn0tt merged 1 commit intomicrosoft:mainfrom
Skn0tt:reapply-doclint-hidden-checks
Jan 27, 2026
Merged

chore(doclint): handle hidden metadata earlier in parsing#38926
Skn0tt merged 1 commit intomicrosoft:mainfrom
Skn0tt:reapply-doclint-hidden-checks

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Jan 23, 2026 •
edited
Loading

This reapplies the doclint improvements from #38882 that were accidentally reverted in #38917.

@Skn0tt
chore(doclint): handle hidden metadata earlier in parsing
16a696a 
This reapplies the doclint improvements from microsoft#38882 that were
accidentally reverted in microsoft#38917.

The changes:
- Check for hidden metadata early in parseMember, before looking up
  the class (allows hiding members on hidden classes)
- Check for hidden metadata in parseArgument for params/options
  (allows hiding individual parameters)
@Skn0tt Skn0tt self-assigned this Jan 23, 2026
@Skn0tt Skn0tt requested a review from dgozman January 23, 2026 14:33
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Test results for "tests 1"

5 failed
❌ [playwright-test] › expect.spec.ts:697 › should not print timed out error message when test times out @macos-latest-node20
❌ [playwright-test] › global-setup.spec.ts:313 › globalSetup should work for auth @macos-latest-node20
❌ [playwright-test] › playwright.trace.spec.ts:345 › should retain traces for interrupted tests @macos-latest-node20
❌ [playwright-test] › reporter-html.spec.ts:1037 › created › should have link for opening HTML attachments in new tab @macos-latest-node20
❌ [playwright-test] › ui-mode-trace.spec.ts:701 › should indicate current test status @macos-latest-node20

4 flaky ⚠️ [chromium-page] › page/page-request-continue.spec.ts:754 › propagate headers cross origin redirect after interception `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:185 › should show snapshots for steps `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:434 › should work behind reverse proxy `@macos-latest-node20`

34664 passed, 695 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Test results for "MCP"

16 failed
❌ [webkit] › mcp/snapshot-mode.spec.ts:58 › should respect --snapshot-mode=incremental @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [chrome] › mcp/tabs.spec.ts:108 › close tab @mcp-macos-15
❌ [chrome] › mcp/video.spec.ts:43 › should work with { saveVideo } (persistent) @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:162 › core › dialog-accept @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:342 › devtools › tracing-start-stop @mcp-macos-15
❌ [chromium] › mcp/core.spec.ts:160 › browser_resize @mcp-macos-15
❌ [chromium] › mcp/tabs.spec.ts:108 › close tab @mcp-macos-15
❌ [chromium] › mcp/test-debug.spec.ts:48 › test_debug (pause/resume) @mcp-macos-15
❌ [chromium] › mcp/test-debug.spec.ts:234 › test_debug / evaluate x 2 @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:342 › devtools › tracing-start-stop @mcp-macos-15
❌ [webkit] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [webkit] › mcp/snapshot-mode.spec.ts:58 › should respect --snapshot-mode=incremental @mcp-macos-15
❌ [webkit] › mcp/test-debug.spec.ts:48 › test_debug (pause/resume) @mcp-macos-15

3090 passed, 300 skipped

Merge workflow run.

@Skn0tt Skn0tt merged commit e5bdfda into microsoft:main Jan 27, 2026
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman dgozman dgozman approved these changes

Assignees

@Skn0tt Skn0tt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Skn0tt @dgozman