Skip to content

chore: update video api and implementation#39054

Merged
dgozman merged 2 commits intomicrosoft:mainfrom
dgozman:chore-video-api-update
Jan 31, 2026
Merged

chore: update video api and implementation#39054
dgozman merged 2 commits intomicrosoft:mainfrom
dgozman:chore-video-api-update

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 30, 2026 •
edited
Loading

  • page.video() is always available.
  • video.path() is available right away upon recording, and throws when no video is being recorded.
  • No path option when stopping, use saveAs() instead.
  • No page did not produce any video frames error anymore - add a single white frame instead.
  • More tests around edge cases.
  • Simplify plumbing.

@dgozman
chore: update video.start/stop api
eed779c 
- Path is available once video file is created.
- No `path` option when stopping, use `saveAs()` instead.
- More tests around edge cases.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@dgozman dgozman changed the title chore: update video.start/stop api chore: update video api and implementation Jan 30, 2026
@dgozman dgozman force-pushed the chore-video-api-update branch from e952824 to ddf0ad2 Compare January 30, 2026 15:22
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

Test results for "tests 1"

4 failed
❌ [firefox-library] › library/browsercontext-events.spec.ts:103 › dialog event should work in popup @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/browsercontext-events.spec.ts:135 › dialog event should work in immediately closed popup @firefox-ubuntu-22.04-node20
❌ [firefox-page] › page/page-event-popup.spec.ts:61 › should be able to capture alert @firefox-ubuntu-22.04-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:669 › update-source-method › should overwrite source when specified in the config @macos-latest-node20

5 flaky ⚠️ [chromium-library] › library/inspector/recorder-api.spec.ts:120 › should type `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:384 › should reveal errors in the sourcetab `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:118 › should collapse repeated console messages for test `@ubuntu-latest-node22`

34256 passed, 662 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

Test results for "MCP"

7 failed
❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:49 › core › click button @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:63 › core › click link @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:283 › save as › screenshot @mcp-macos-15
❌ [chrome] › mcp/cli.spec.ts:298 › save as › screenshot --filename @mcp-macos-15
❌ [chrome] › mcp/test-debug.spec.ts:167 › test_debug (pause/snapshot/resume) @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:220 › keyboard › press @mcp-macos-15

1 flaky ⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest`

3607 passed, 129 skipped

Merge workflow run.

pavelfeldman
pavelfeldman approved these changes Jan 31, 2026
View reviewed changes
docs/src/api/class-video.md
// ... perform actions ...
await page.video().stop({ path: 'video.webm' });
await page.video().stop();
await page.video().saveAs('video.webm');
Copy link
Member

@pavelfeldman pavelfeldman Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really unusual API for us, we recommend to always write 2 lines instead of passing path into one. screenshot({ path }), pdf({ path }), etc.

Copy link
Contributor Author

@dgozman dgozman Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will follow up!

@dgozman dgozman merged commit d039c40 into microsoft:main Jan 31, 2026
28 of 32 checks passed
This was referenced Jan 31, 2026
Open
Open
Open
yury-s
yury-s reviewed Feb 1, 2026
View reviewed changes
@dgozman dgozman mentioned this pull request Feb 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-s yury-s yury-s left review comments

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dgozman @pavelfeldman @yury-s