fix(cli): minimist should not turn strings into numbers#39148
Open
Skn0tt wants to merge 6 commits intomicrosoft:mainfrom
Open
fix(cli): minimist should not turn strings into numbers#39148Skn0tt wants to merge 6 commits intomicrosoft:mainfrom
Skn0tt wants to merge 6 commits intomicrosoft:mainfrom
Conversation
Skn0tt
commented
Feb 5, 2026
| Object.entries(commands).map(([name, command]) => [name, generateCommandHelp(command)]) | ||
| ), | ||
| stringOptions: [...stringOptions], | ||
| booleanOptions: [...booleanOptions], |
Member
Author
There was a problem hiding this comment.
this outputs a lot more booleanOptions than we currently have:
"stringOptions": [
"browser",
"config",
"profile",
"modifiers",
"filename",
"domain",
"path",
"body",
"content-type",
"remove-header"
],
"booleanOptions": [
"extension",
"headed",
"persistent",
"submit",
"clear",
"full-page",
"httpOnly",
"secure",
"skills",
"static"
]
dgozman
reviewed
Feb 5, 2026
| const argv = process.argv.slice(2); | ||
| const args: MinimistArgs = require('minimist')(argv, { boolean: booleanOptions }); | ||
| for (const option of booleanOptions) { | ||
| const args: MinimistArgs = require('minimist')(argv, { boolean: [...help.booleanOptions, 'help', 'version'], string: [...help.stringOptions, '_'] }); |
Contributor
There was a problem hiding this comment.
Does this work with mousemove? IIRC, it has two number arguments.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"1 failed 4713 passed, 135 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes microsoft/playwright-cli#235