Skip to content

feat: make artifactsDir configurable via browserType.launch() and run-server CLI#39426

Merged
yury-s merged 6 commits intomicrosoft:mainfrom
yury-s:feature/configurable-artifacts-dir
Feb 27, 2026
Merged

feat: make artifactsDir configurable via browserType.launch() and run-server CLI#39426
yury-s merged 6 commits intomicrosoft:mainfrom
yury-s:feature/configurable-artifacts-dir

Conversation

@yury-s
Copy link
Member

@yury-s yury-s commented Feb 26, 2026

@yury-s yury-s requested review from dgozman and pavelfeldman and removed request for pavelfeldman February 26, 2026 04:29
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@yury-s yury-s force-pushed the feature/configurable-artifacts-dir branch from ccda449 to 261a340 Compare February 26, 2026 20:55
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

};
}

artifactsDir() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this change?

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@yury-s yury-s merged commit 6848d2d into microsoft:main Feb 27, 2026
31 of 36 checks passed
@yury-s yury-s deleted the feature/configurable-artifacts-dir branch February 27, 2026 01:44
@github-actions
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [webkit-library] › library/download.spec.ts:399 › download event › should save downloads to artifactsDir @webkit-ubuntu-22.04-node20
❌ [playwright-test] › reporter-line.spec.ts:193 › created › should show error context with relative path @macos-latest-node20

11 flaky ⚠️ [chromium-library] › library/browser.spec.ts:24 › should create new page @smoke `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/browser.spec.ts:24 › should create new page @smoke `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/browser.spec.ts:24 › should create new page @smoke `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/browser.spec.ts:24 › should create new page @smoke `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/browser.spec.ts:24 › should create new page @smoke `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browser.spec.ts:24 › should create new page @smoke `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browser.spec.ts:24 › should create new page @smoke `@webkit-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:297 › should detect mime type `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:185 › should watch new file `@windows-latest-node20`

38628 passed, 843 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

15 failed
❌ [chrome] › mcp/init-page.spec.ts:21 › --init-page @mcp-windows-latest
❌ [chrome] › mcp/init-page.spec.ts:39 › --init-page w/ --init-script @mcp-windows-latest
❌ [chromium] › mcp/init-page.spec.ts:21 › --init-page @mcp-windows-latest
❌ [chromium] › mcp/init-page.spec.ts:39 › --init-page w/ --init-script @mcp-windows-latest
❌ [chromium] › mcp/roots.spec.ts:47 › check that trace is saved in workspace @mcp-windows-latest
❌ [firefox] › mcp/init-page.spec.ts:21 › --init-page @mcp-windows-latest
❌ [firefox] › mcp/init-page.spec.ts:39 › --init-page w/ --init-script @mcp-windows-latest
❌ [webkit] › mcp/init-page.spec.ts:21 › --init-page @mcp-windows-latest
❌ [webkit] › mcp/init-page.spec.ts:39 › --init-page w/ --init-script @mcp-windows-latest
❌ [msedge] › mcp/init-page.spec.ts:21 › --init-page @mcp-windows-latest
❌ [msedge] › mcp/init-page.spec.ts:39 › --init-page w/ --init-script @mcp-windows-latest
❌ [msedge] › mcp/tracing.spec.ts:21 › check that trace is saved with --save-trace @mcp-windows-latest
❌ [firefox] › mcp/cli-session.spec.ts:21 › list @mcp-macos-15
❌ [firefox] › mcp/http.spec.ts:199 › http transport browser lifecycle (persistent) @mcp-macos-15
❌ [webkit] › mcp/sse.spec.ts:171 › sse transport browser lifecycle (persistent) @mcp-macos-15

5118 passed, 171 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants