Skip to content

chore(cdp): event name -> method #39570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 1 commit into from
Mar 9, 2026
Merged

chore(cdp): event name -> method #39570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/api/class-cdpsession.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ Emitted when the session is closed, either because the target was closed or `ses
* since: v1.59
* langs: js
- argument: <[Object]>
- `name` <[string]> CDP event name.
- `method` <[string]> CDP event name.
- `params` ?<[Object]> CDP event parameters.

Emitted for every CDP event received from the session. Allows subscribing to all CDP events at once without knowing
Expand Down
12 changes: 6 additions & 6 deletions packages/playwright-client/types/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16058,7 +16058,7 @@ export interface CDPSession {
/**
* CDP event name.
*/
name: string;
method: string;

/**
* CDP event parameters.
Expand All @@ -16078,7 +16078,7 @@ export interface CDPSession {
/**
* CDP event name.
*/
name: string;
method: string;

/**
* CDP event parameters.
Expand Down Expand Up @@ -16108,7 +16108,7 @@ export interface CDPSession {
/**
* CDP event name.
*/
name: string;
method: string;

/**
* CDP event parameters.
Expand All @@ -16128,7 +16128,7 @@ export interface CDPSession {
/**
* CDP event name.
*/
name: string;
method: string;

/**
* CDP event parameters.
Expand All @@ -16148,7 +16148,7 @@ export interface CDPSession {
/**
* CDP event name.
*/
name: string;
method: string;

/**
* CDP event parameters.
Expand Down Expand Up @@ -16178,7 +16178,7 @@ export interface CDPSession {
/**
* CDP event name.
*/
name: string;
method: string;

/**
* CDP event parameters.
Expand Down
6 changes: 3 additions & 3 deletions packages/playwright-core/src/client/cdpSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ export class CDPSession extends ChannelOwner<channels.CDPSessionChannel> impleme
constructor(parent: ChannelOwner, type: string, guid: string, initializer: channels.CDPSessionInitializer) {
super(parent, type, guid, initializer);

this._channel.on('event', ({ method, params }) => {
this.emit(method, params);
this.emit('event', { name: method, params });
this._channel.on('event', event => {
this.emit(event.method, event.params);
this.emit('event', event);
});

this._channel.on('close', () => {
Expand Down
12 changes: 6 additions & 6 deletions packages/playwright-core/types/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16058,7 +16058,7 @@ export interface CDPSession {
/**
* CDP event name.
*/
name: string;
method: string;

/**
* CDP event parameters.
Expand All @@ -16078,7 +16078,7 @@ export interface CDPSession {
/**
* CDP event name.
*/
name: string;
method: string;

/**
* CDP event parameters.
Expand Down Expand Up @@ -16108,7 +16108,7 @@ export interface CDPSession {
/**
* CDP event name.
*/
name: string;
method: string;

/**
* CDP event parameters.
Expand All @@ -16128,7 +16128,7 @@ export interface CDPSession {
/**
* CDP event name.
*/
name: string;
method: string;

/**
* CDP event parameters.
Expand All @@ -16148,7 +16148,7 @@ export interface CDPSession {
/**
* CDP event name.
*/
name: string;
method: string;

/**
* CDP event parameters.
Expand Down Expand Up @@ -16178,7 +16178,7 @@ export interface CDPSession {
/**
* CDP event name.
*/
name: string;
method: string;

/**
* CDP event parameters.
Expand Down
2 changes: 1 addition & 1 deletion tests/library/chromium/session.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ it('should emit event for each CDP event', async function({ page, server }) {
client.on('event', event => events.push(event));
await page.goto(server.EMPTY_PAGE);
expect(events.length).toBeGreaterThan(0);
const requestEvent = events.find(e => e.name === 'Network.requestWillBeSent');
const requestEvent = events.find(e => e.method === 'Network.requestWillBeSent');
expect(requestEvent).toBeTruthy();
expect(requestEvent.params.request.url).toBe(server.EMPTY_PAGE);
});
Expand Down
Loading