Skip to content

feat(api): return Disposable from Video.start and Screencast.start#39712

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:disposable-start-methods
Mar 17, 2026
Merged

feat(api): return Disposable from Video.start and Screencast.start#39712
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:disposable-start-methods

Conversation

@pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented Mar 17, 2026

Summary

  • Video.start() and Screencast.start() now return a Disposable that calls stop() when disposed
  • Move path option from Video.stop() to Video.start() so the save destination is declared upfront
  • Add tests for the disposable variant of stopping video and screencast

@pavelfeldman
feat(api): return Disposable from Video.start and Screencast.start
a004f17 
Move Video path option from stop() to start() so the save destination
is declared upfront. Both Video.start and Screencast.start now return
a Disposable that calls stop() when disposed.
pavelfeldman added a commit to pavelfeldman/playwright that referenced this pull request Mar 17, 2026
@pavelfeldman
fix(api): migrate Screencast from events to onFrame callback
144777d 
Fixes: microsoft#39712
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

Test results for "MCP"

1 failed
❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest

1 flaky ⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest`

5337 passed, 186 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

Test results for "tests 1"

9 failed
❌ [default] › run-tests.spec.ts:226 › should show error message @vscode-extension
❌ [default] › run-tests.spec.ts:278 › should show soft error messages @vscode-extension
❌ [default] › run-tests.spec.ts:818 › should report project-specific failures @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:226 › should show error message @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:278 › should show soft error messages @vscode-extension
❌ [default-reuse] › run-tests.spec.ts:818 › should report project-specific failures @vscode-extension
❌ [default-trace] › run-tests.spec.ts:226 › should show error message @vscode-extension
❌ [default-trace] › run-tests.spec.ts:278 › should show soft error messages @vscode-extension
❌ [default-trace] › run-tests.spec.ts:818 › should report project-specific failures @vscode-extension

4 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@chromium-ubuntu-22.04-arm-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@webkit-ubuntu-22.04-node20`

38782 passed, 847 skipped

Merge workflow run.

@pavelfeldman pavelfeldman merged commit 1ed53ac into microsoft:main Mar 17, 2026
37 of 39 checks passed
This was referenced Mar 17, 2026
Open
Open
Open
pavelfeldman added a commit to pavelfeldman/playwright that referenced this pull request Mar 18, 2026
@pavelfeldman
fix(api): migrate Screencast from events to onFrame callback
59eae36 
Fixes: microsoft#39712
pavelfeldman added a commit to pavelfeldman/playwright that referenced this pull request Mar 18, 2026
@pavelfeldman
fix(api): migrate Screencast from events to onFrame callback
2bdc7ea 
Fixes: microsoft#39712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman dgozman dgozman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman @dgozman