Merged
Conversation
- Rename onFrame callback argument from `buffer: Buffer` to `frame: { data: Buffer }`
- Rename `maxSize` option to `preferredSize` with updated description noting the size may not match if screencast is already running (e.g. for tracing or video)
fix(utils): add dir name to 'No packages found' error in generate_third_party_notice
fix(api): reuse existing screencast when already running instead of throwing
remove stop method
multiple listeners
dgozman
reviewed
Mar 19, 2026
| onClose(handler: (code: number | undefined, reason: string | undefined) => any): void; | ||
| } | ||
|
|
||
| export interface Screencast { |
Member
Author
There was a problem hiding this comment.
Because we don't have better means to specify callback types, see other examples.
| * langs: js | ||
| - `onFrame` <[function]\([Buffer]\): [Promise<any>|any]> | ||
| - `onFrame` <[function]\([Object]\): [Promise<any>|any]> | ||
| - `data` <[Buffer]> JPEG-encoded frame data. |
Contributor
There was a problem hiding this comment.
Do we expect more fields here?
Member
Author
There was a problem hiding this comment.
Yes, we already had width/height but then hid them. There is a chance we add such metadata in the future.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Mar 19, 2026
Contributor
Test results for "tests 1"6 flaky38815 passed, 845 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 5506 passed, 343 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffer: Buffertoframe: { data: Buffer }maxSizeoption topreferredSizewith updated description noting the size may not match if screencast is already running (e.g. for tracing or video)