feat(api): add Screencast.stop() and enforce single listener#39775
Merged
yury-s merged 1 commit intomicrosoft:mainfrom Mar 19, 2026
Merged
feat(api): add Screencast.stop() and enforce single listener#39775yury-s merged 1 commit intomicrosoft:mainfrom
yury-s merged 1 commit intomicrosoft:mainfrom
Conversation
Replace the disposable pattern from screencast.start() with an explicit screencast.stop() method. Only one listener is allowed at a time; starting a second one throws 'Screencast is already started'.
dgozman
approved these changes
Mar 19, 2026
Contributor
Test results for "tests 1"1 failed 5 flaky38815 passed, 845 skipped Merge workflow run. |
Contributor
Test results for "MCP"5494 passed, 343 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
screencast.stop()method as the canonical way to stop a screencast sessiondisposable.dispose()) withpage.screencast.stop()in tests and dashboard controllerscreencast.start()now throws'Screencast is already started'if called while a screencast is already active