feat(locator): add description option to getByRole#40083
Open
Skn0tt wants to merge 4 commits intomicrosoft:mainfrom
Open
feat(locator): add description option to getByRole#40083Skn0tt wants to merge 4 commits intomicrosoft:mainfrom
Skn0tt wants to merge 4 commits intomicrosoft:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"6442 passed, 383 skipped Merge workflow run. |
Contributor
Test results for "tests 1"5 flaky39220 passed, 846 skipped Merge workflow run. |
nstepien
reviewed
Apr 9, 2026
There was a problem hiding this comment.
Would it be worth adding a test for an element with both aria-description and aria-describedby attributes?
When both attributes are set, and aria-describedby has a valid target element, then aria-description is ignored.
aria-describedby can also have multiple IDs.
It looks like if the aria-describedby has, for example, the same ID twice, then the accessible description will have the same text twice as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #39932