fix(html-reporter): align screenshot slider size labels#40101
Open
alexchexes wants to merge 2 commits intomicrosoft:mainfrom
Open
fix(html-reporter): align screenshot slider size labels#40101alexchexes wants to merge 2 commits intomicrosoft:mainfrom
alexchexes wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
pavelfeldman
reviewed
Apr 8, 2026
Member
pavelfeldman
left a comment
pavelfeldman
left a comment
There was a problem hiding this comment.
Please remove the test and stray changes, your cosmetic change does not warrant a test.
Author
|
@pavelfeldman Done |
pavelfeldman
approved these changes
Apr 8, 2026
Contributor
Test results for "MCP"6442 passed, 383 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 failed 7 flaky39102 passed, 846 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the order of the Expected/Actual size labels that appear above the Slider view in the Image mismatch section of a failed test report, when the Expected and Actual image sizes don't match.
The problem with the existing label order was that the slider shows the expected image on the right and the actual image on the left (which is already counterintuitive, but that's a separate topic), while the labels were reversed: the
Expected W x Happeared on the left and theActual W x Happeared on the right. Together, this made the Slider UI pretty confusing.This PR only changes the label order; it doesn't change the slider behavior.
Before:
After: