fix(text selector): make quoted selector match by text nodes#5603
Merged
Conversation
This change turns quoted match to be case-sensitive (as before), but not strictly full-string for the whole element's text. This is a fix for a case where element contains text nodes and child elements: ```html <div>text1<span>child node</span>text2</div> ``` We now match this div by `text="text1"` and `text="text2"`.
pavelfeldman
approved these changes
Feb 24, 2021
aslushnikov
pushed a commit
to aslushnikov/playwright
that referenced
this pull request
Feb 25, 2021
…icrosoft#5603) This change turns quoted match to be case-sensitive (as before), but not strictly full-string for the whole element's text. This is a fix for a case where element contains text nodes and child elements: ```html <div>text1<span>child node</span>text2</div> ``` We now match this div by `text="text1"` and `text="text2"`.
aslushnikov
pushed a commit
to aslushnikov/playwright
that referenced
this pull request
Feb 25, 2021
aslushnikov
added a commit
that referenced
this pull request
Feb 25, 2021
Hello @dgozman , What's the recommended way to do strict full string search? If I have -
What's the recommended way to select second div? |
|
I had element like this: My selector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change turns quoted match to be case-sensitive (as before),
but not strictly full-string for the whole element's text.
This is a fix for a case where element contains text nodes and child elements:
We now match this div by
text="text1"andtext="text2".