chore: windows bots via github actions#678
Merged
aslushnikov merged 4 commits intomicrosoft:masterfrom Jan 29, 2020
Merged
Conversation
Contributor
|
/rebase |
aesyondu
reviewed
Feb 18, 2020
| "coverage": "cross-env COVERAGE=true npm run unit", | ||
| "fcoverage": "cross-env COVERAGE=true BROWSER=firefox npm run unit", | ||
| "wcoverage": "cross-env COVERAGE=true BROWSER=webkit npm run unit", | ||
| "ccoverage": "cross-env COVERAGE=true npm run ctest", |
Contributor
There was a problem hiding this comment.
npm test is failing:
> playwright-core@0.11.1-post test /Users/aes/sandbox/playwright
> npm run lint --silent && npm run coverage && npm run test-doclint && node utils/testrunner/test/test.js
0 failures, 0 warnings.
DocLint Finished in 7.388 seconds
npm ERR! missing script: coverage
npm ERR!
npm ERR! Did you mean one of these?
npm ERR! ccoverage
npm ERR! fcoverage
npm ERR! wcoverage
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/aes/.npm/_logs/2020-02-18T23_57_11_890Z-debug.log
npm ERR! Test failed. See above for more details.
Contributor
There was a problem hiding this comment.
Should test script be changed to:
"test": "npm run lint --silent && npm run ccoverage && npm run test-doclint && node utils/testrunner/test/test.js",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mac will come in a follow up!
As a drive-by, removed
npm buildeverywhere, becausenpm installalready runs build.