chore(registry): refactor logic of what browsers to download to top level#9078
Merged
yury-s merged 1 commit intoSep 22, 2021
Merged
Conversation
yury-s
approved these changes
Sep 22, 2021
sidharthv96
added a commit
to sidharthv96/playwright
that referenced
this pull request
Sep 24, 2021
* upstream/master: (33 commits) chore: migrate expect(locator).toMatchText to protocol (microsoft#9117) browser(webkit): fix text padding (microsoft#9114) test: unflake "should have correct snapshot size" (microsoft#9099) fix: make Serializable type any (microsoft#9059) feat(test runner): add some fixture debugging (microsoft#8918) chore(typescript): bump typescript to v4.4.3 (microsoft#9087) test: add failing WebKit navigation test (microsoft#9097) fix(firefox): use global eval in injected script (microsoft#9101) feat(launch): connect to process.env.SELENIUM_REMOTE_URL instead of local launch (microsoft#9056) test: unflake "should close the context without awaiting the failed download" (microsoft#9094) chore: simplify dom tasks (microsoft#9089) test: unflake inspector/pause.spec.ts (microsoft#9096) test: unflake "should fail when frame detaches" (microsoft#9095) test: unflake "should timeout in socket while connecting" (microsoft#9093) fix(junit): produce a single system-out entry (microsoft#9091) fix(css selector): absolutize relative CSS selectors (microsoft#9088) feat(fetch): support options in playwright._newRequest (microsoft#9061) chore(registry): refactor logic of what browsers to download to top level (microsoft#9078) chore(babel): rename .babelrc to babel.config.json (microsoft#9076) docs: improve ignorehttpserrors description (microsoft#9081) ...
mxschmitt
added a commit
that referenced
this pull request
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the monorepo refactoring.
Today each of our packages has a browsers.json that sets some executables as download by default.
When packages depend on core, there is only one browsers.json. So there needs to be a method to
download only a few browsers by name. While tracing the code I refactored it to remove optional
methods so that default browsers aren't downloaded by accident.