feat(reporters): Add error position to JSON Report#9151
Conversation
| body?: string; | ||
| contentType: string; | ||
| }[]; | ||
| line?: number; |
There was a problem hiding this comment.
Let's instead do errorLocation?: { line: number, column: number }.
There was a problem hiding this comment.
Sure, was following the convention in
playwright/src/test/reporters/json.ts
Lines 39 to 54 in 0bcd092
There was a problem hiding this comment.
@dgozman which approach should we take?
I'd prefer the errorLocation approach, but that would deviate from the convention for the parents of that object.
The way I've seen in jest report is a position object with line and col like you suggested.
There was a problem hiding this comment.
I feel strongly that test result does not have a line/column because it is not defined in the source like suite or test. errorLocation works nicely here, in line with https://playwright.dev/docs/api/class-location.
There was a problem hiding this comment.
Done.
Just curious, shouldn't JSONReportSuite and JSONReportSpec be using the Location class as file, line and column are being used there?
| body?: string; | ||
| contentType: string; | ||
| }[]; | ||
| line?: number; |
There was a problem hiding this comment.
I feel strongly that test result does not have a line/column because it is not defined in the source like suite or test. errorLocation works nicely here, in line with https://playwright.dev/docs/api/class-location.
dgozman
left a comment
dgozman
left a comment
There was a problem hiding this comment.
Looks great, thank you for the PR!
* upstream/master: (21 commits) fix(test runner): do not write missing snapshot until the last retry (microsoft#9246) feat(reporters): Add error position to JSON Report (microsoft#9151) feat(fetch): import/export storageState (microsoft#9244) fix: allow binary response interception (microsoft#9236) test(cookies): add a test for SameSite=None cookies (microsoft#9242) feat(webkit): roll WebKit to 1550 (microsoft#9239) test: add test for downloading PDF files (microsoft#9235) fix: leaking route handlers when times is used in Page.route (microsoft#9234) chore: upgrade commander.js to version 8 (microsoft#9230) feat(fetch): store cookies between requests (microsoft#9221) fix(selenium connect): register in gracefullyCloseAll for driver cleanup (microsoft#9218) fix(toBeHidden): return true to missing elements (microsoft#9205) chore: fix PlaywrightClient disconnection logic (microsoft#9149) fix(expect): beautiful expect stacks (microsoft#9204) feat(fetch): support ignoreHTTPSErrors option (microsoft#9206) feat(api): introduce locator.waitFor (microsoft#9200) feat(fetch): send Playwright as default user-agent for global fetch (microsoft#9195) feat(test runner): collect test error from worker teardown (microsoft#9190) test: add tests for Cross-Origin-Opener-Policy navigation (microsoft#9184) test: get response body for COOP responses (microsoft#9196) ...
…tionWithBaseChange * upstream/master: (21 commits) fix(test runner): do not write missing snapshot until the last retry (microsoft#9246) feat(reporters): Add error position to JSON Report (microsoft#9151) feat(fetch): import/export storageState (microsoft#9244) fix: allow binary response interception (microsoft#9236) test(cookies): add a test for SameSite=None cookies (microsoft#9242) feat(webkit): roll WebKit to 1550 (microsoft#9239) test: add test for downloading PDF files (microsoft#9235) fix: leaking route handlers when times is used in Page.route (microsoft#9234) chore: upgrade commander.js to version 8 (microsoft#9230) feat(fetch): store cookies between requests (microsoft#9221) fix(selenium connect): register in gracefullyCloseAll for driver cleanup (microsoft#9218) fix(toBeHidden): return true to missing elements (microsoft#9205) chore: fix PlaywrightClient disconnection logic (microsoft#9149) fix(expect): beautiful expect stacks (microsoft#9204) feat(fetch): support ignoreHTTPSErrors option (microsoft#9206) feat(api): introduce locator.waitFor (microsoft#9200) feat(fetch): send Playwright as default user-agent for global fetch (microsoft#9195) feat(test runner): collect test error from worker teardown (microsoft#9190) test: add tests for Cross-Origin-Opener-Policy navigation (microsoft#9184) test: get response body for COOP responses (microsoft#9196) ...
2 participants
@mxschmitt this is the fix for the initial problem with #9147
Will raise the PR for annotations soon.