Skip to content

fix(create-playwright): add extra -- for the debug script #9257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 2 commits into from
Oct 4, 2021
Merged

fix(create-playwright): add extra -- for the debug script #9257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a31e9e0
fix(create-playwright): add extra -- for the debug script
elaichenkov Oct 1, 2021
d7b699a
nits
mxschmitt Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/create-playwright/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,13 @@ class Generator {
${colors.cyan(commandToRunTests(this.packageManager))}
Runs the end-to-end tests.

${colors.cyan(commandToRunTests(this.packageManager) + ' -- --project="Desktop Chrome"')}
${colors.cyan(commandToRunTests(this.packageManager, '--project="Desktop Chrome"'))}
Runs the tests only on Desktop Chrome.

${colors.cyan(commandToRunTests(this.packageManager) + ` -- ${exampleSpecPath}`)}
${colors.cyan(commandToRunTests(this.packageManager, exampleSpecPath))}
Runs the tests of a specific file.
${colors.cyan(`${commandToRunTests(this.packageManager)} --debug`)}

${colors.cyan(`${commandToRunTests(this.packageManager, '--debug')}`)}
Runs the tests in debug mode.

We suggest that you begin by typing:
Expand All @@ -182,10 +182,10 @@ Happy hacking! 🎭`);
}
}

export function commandToRunTests(packageManager: 'npm' | 'yarn') {
export function commandToRunTests(packageManager: 'npm' | 'yarn', args?: string) {
if (packageManager === 'yarn')
return `yarn ${PACKAGE_JSON_TEST_SCRIPT_CMD}`;
return `npm run ${PACKAGE_JSON_TEST_SCRIPT_CMD}`;
return `yarn ${PACKAGE_JSON_TEST_SCRIPT_CMD}${args ? (' ' + args) : ''}`;
return `npm run ${PACKAGE_JSON_TEST_SCRIPT_CMD}${args ? (' -- ' + args) : ''}`;
}

(async () => {
Expand Down