Skip to content

fix: ReuseBrowserContextStorage Spelling #9296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 1 commit into from
Oct 4, 2021
Merged

fix: ReuseBrowserContextStorage Spelling #9296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/test/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ type TestFixtures = PlaywrightTestArgs & PlaywrightTestOptions & {
type WorkerAndFileFixtures = PlaywrightWorkerArgs & PlaywrightWorkerOptions & {
_browserType: BrowserType;
_artifactsDir: () => string,
_reuseBrowerContext: ReuseBrowerContextStorage,
_reuseBrowserContext: ReuseBrowserContextStorage,
};

class ReuseBrowerContextStorage {
class ReuseBrowserContextStorage {
private _browserContext?: BrowserContext;
private _uniqueOrigins = new Set<string>();
private _options?: BrowserContextOptions;
Expand Down Expand Up @@ -387,14 +387,14 @@ export const test = _baseTest.extend<TestFixtures, WorkerAndFileFixtures>({
}));
}, { auto: true }],

_reuseBrowerContext: [new ReuseBrowerContextStorage(), { scope: 'worker' }],
_reuseBrowserContext: [new ReuseBrowserContextStorage(), { scope: 'worker' }],

context: async ({ browser, video, _artifactsDir, _reuseBrowerContext, _combinedContextOptions }, use, testInfo) => {
context: async ({ browser, video, _artifactsDir, _reuseBrowserContext, _combinedContextOptions }, use, testInfo) => {
const hook = hookType(testInfo);
if (hook)
throw new Error(`"context" and "page" fixtures are not supported in ${hook}. Use browser.newContext() instead.`);
if (_reuseBrowerContext.isEnabled()) {
const context = await _reuseBrowerContext.obtainContext(browser, _combinedContextOptions);
if (_reuseBrowserContext.isEnabled()) {
const context = await _reuseBrowserContext.obtainContext(browser, _combinedContextOptions);
await use(context);
return;
}
Expand Down Expand Up @@ -449,9 +449,9 @@ export const test = _baseTest.extend<TestFixtures, WorkerAndFileFixtures>({
}
},

page: async ({ context, _reuseBrowerContext }, use) => {
if (_reuseBrowerContext.isEnabled()) {
await use(await _reuseBrowerContext.obtainPage());
page: async ({ context, _reuseBrowserContext }, use) => {
if (_reuseBrowserContext.isEnabled()) {
await use(await _reuseBrowserContext.obtainPage());
return;
}
await use(await context.newPage());
Expand Down