fix(route): allow allHeaders call within route#9300
Merged
Conversation
pavelfeldman
force-pushed
the
route_headers
branch
from
cbec999 to
0c5e12b
Compare
yury-s
approved these changes
Oct 4, 2021
| it('should contain raw header', async ({ page, server }) => { | ||
| let headers: any; | ||
| await page.route('**/*', async route => { | ||
| headers = await route.request().allHeaders(); |
Member
There was a problem hiding this comment.
Check that it actually returns expected headers?
Member
Author
There was a problem hiding this comment.
I don't think we are returning raw headers here, so I only check that it accept one exists.
| this._rawRequestHeadersPromise!.resolve(headers); | ||
| } | ||
|
|
||
| async rawRequestHeaders(): Promise<NameValue[]> { |
Member
There was a problem hiding this comment.
Please add a comment explaining 3 ways the raw headers could be received
pavelfeldman
force-pushed
the
route_headers
branch
from
0c5e12b to
6f21c60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9298