fix: copy msdia140.dll to build output root#46
Merged
Conversation
msdia140.dll was only landing in amd64/arm64/x86 subdirectories (via the TraceEvent.SupportFiles NuGet package) but PDBDebugInfoProvider references it at AppContext.BaseDirectory for COM registration via regsvr32. Add Content items to ProfileExplorerUI.csproj to copy the correct arch variant (src/external/msdia140.dll for x64, src/external/arm64/msdia140.dll for ARM64) to the output root. The installer already handled this via xcopy in prepare-out.cmd, but regular dev builds did not.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ProfileExplorer UI project to ensure msdia140.dll is present in the build output root so DIA COM registration via AppContext.BaseDirectory works in developer builds (not just installer builds).
Changes:
- Adds conditional
Contentitems inProfileExplorerUI.csprojto copymsdia140.dllinto the output root. - Selects the ARM64 vs non-ARM64 DLL source path based on build configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
$(PlatformTarget) is overridden unconditionally to AnyCPU later in the project file, so the ARM64 ItemGroup condition never triggered. $(Platform) is set at the MSBuild invocation level and correctly distinguishes ARM64 from AnyCPU builds.
jhpohovey
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
msdia140.dll was only landing in amd64/arm64/x86 subdirectories (via the TraceEvent.SupportFiles NuGet package) but PDBDebugInfoProvider references it at AppContext.BaseDirectory for COM registration via regsvr32.
Add Content items to ProfileExplorerUI.csproj to copy the correct arch variant (src/external/msdia140.dll for x64, src/external/arm64/msdia140.dll for ARM64) to the output root. The installer already handled this via xcopy in prepare-out.cmd, but regular dev builds did not.