Skip to content

feat: add brace expansion support for glob patterns#367

Closed
karthiknadig wants to merge 1 commit intomainfrom
bug/issue-364
Closed

feat: add brace expansion support for glob patterns#367
karthiknadig wants to merge 1 commit intomainfrom
bug/issue-364

Conversation

@karthiknadig
Copy link
Member

Adds {a,b} brace expansion support to glob pattern handling, enabling patterns like ./**/{bin,Scripts}/python{,.exe} to work as search paths.

Changes

  • Brace expansion in pet-fs/src/glob.rs: expands {a,b} groups before passing patterns to the glob crate (which doesn't support braces natively)
  • Safety cap: expansion limited to 1024 patterns to prevent exponential blowup
  • Progress logging: trace-level logs during glob expansion showing pattern, match count, and elapsed time
  • Robust detection: is_glob_pattern() now correctly identifies brace patterns (requires matched {...} pair with comma)
  • JSONRPC docs: documented brace expansion syntax and example in searchPaths

Fixes #366

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 62.7%
Base Branch Coverage 62.7%
Delta 0% ➖

Coverage unchanged.

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

Performance Report (Linux) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 1ms 1ms 1ms 0ms 0%
Full Refresh 74ms 289ms 96ms -22ms -20.0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 63ms 555ms 66ms -3ms
Full Refresh 126ms 27477ms 114ms 12ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

Performance Report (Windows) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 10ms 13ms 9ms 1ms 11.1%
Full Refresh 148ms 3082ms 165ms -17ms -10.3%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 58.89%
Base Branch Coverage 58.89%
Delta 0% ➖

Coverage unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

accept direct path to interpreter as search path

1 participant