Skip to content

fix: tolerate pyenv patch version mismatch in CI test (Fixes #371)#372

Merged
karthiknadig merged 1 commit intomainfrom
bug/issue-371
Mar 5, 2026
Merged

fix: tolerate pyenv patch version mismatch in CI test (Fixes #371)#372
karthiknadig merged 1 commit intomainfrom
bug/issue-371

Conversation

@karthiknadig
Copy link
Member

The CI test verify_validity_of_discovered_envs fails when pyenv's directory name version (e.g. 3.12.13) doesn't match the binary's sys.version (e.g. 3.12.12) during CPython version transitions.

Changes:

  • For Pyenv environments, tolerate patch-level version mismatches in both verify_validity_of_interpreter_info and compare_environments, asserting major.minor still matches
  • Use splitn(3, '.') for robust major.minor extraction (handles dev/alpha versions)
  • Log a warn!() diagnostic when a patch mismatch is detected
  • All other environment types retain the strict full-version assertion

Fixes #371

@karthiknadig karthiknadig requested a review from Copilot March 5, 2026 18:40
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 64.0%
Base Branch Coverage 64.0%
Delta 0% ➖

Coverage unchanged.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Performance Report (Linux) ➖

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 1ms 1ms 1ms 0ms 0%
Full Refresh 98ms 251ms 97ms 1ms 0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Performance Report (Windows) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 9ms 12ms 11ms -2ms -18.2%
Full Refresh 165ms 1506ms 229ms -64ms -27.9%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 60.21%
Base Branch Coverage 60.21%
Delta 0% ➖

Coverage unchanged.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 81ms 770ms 47ms 34ms
Full Refresh 165ms 31965ms 101ms 64ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@karthiknadig karthiknadig enabled auto-merge (squash) March 5, 2026 18:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@karthiknadig karthiknadig merged commit 5ff1eb6 into main Mar 5, 2026
30 checks passed
@karthiknadig karthiknadig deleted the bug/issue-371 branch March 5, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI test verify_validity_of_discovered_envs fails due to pyenv 3.12 minor version update

3 participants