This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Actually populate buffer when reloading Ast#1203
Merged
MikhailArkhipov merged 1 commit intomicrosoft:masterfrom Jun 12, 2019
Merged
Actually populate buffer when reloading Ast#1203MikhailArkhipov merged 1 commit intomicrosoft:masterfrom
MikhailArkhipov merged 1 commit intomicrosoft:masterfrom
Conversation
MikhailArkhipov
approved these changes
Jun 12, 2019
jakebailey
added a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1202.
LoadContent()gets the content, but does nothing with it. The other overload is the one with side effects, so call it instead.There are probably other fixups that could be done in this area (the LibraryAnalysis constructor having side effects and clearing out things it's passed makes things complicated), but this is the minimal change until the double-final-analysis thing is fixed.