This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Suppressing binary operation lint message#1319
Merged
CTrando merged 5 commits intomicrosoft:masterfrom Jul 15, 2019
Merged
Conversation
Contributor
Author
|
Ran tests and all pass. |
|
Actually, don't suppress it wholesale. If type is unknown it should be considered compatible. There are always going to be cases when we can't figure out some type. |
Member
|
The problem is that we are getting cases where we infer the wrong thing (not just nothing), and then lint based on that behavior. We added this with the assumption that we always get the builtin types right, but we have cases where our backup cases in some places cause lint messages in others. I'm not sure if we want to surface all of these false positives... |
jakebailey
suggested changes
Jul 15, 2019
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
I think we're just going to remove all of this code for now, rather than having it run and go nowhere.
CTrando
force-pushed
the
scratch/SuppressBinaryOp
branch
from
3673741 to
3170969
Compare
…e types (microsoft#1254)" This is due to the fact that current operator type checking is too inaccurate to give diagnostics - operator overloading is a challenge to face for the future This reverts commit 753220f.
jakebailey
approved these changes
Jul 15, 2019
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
* Revert "Adding diagnostic error on binary operations with incompatible types (microsoft#1254)" This is due to the fact that current operator type checking is too inaccurate to give diagnostics - operator overloading is a challenge to face for the future This reverts commit 753220f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1311
when we have
we first evaluate
we say that pathlib.Path.home() is an unknown type, so doing this operation we get a string as a result.
Then we do
which it thinks is an unsupported operand.
@jakebailey and I discussed, and we concluded there was not much we could do but just suppress this diagnostic for now. Operator overloading will continue to be an issue for this diagnostic.