Merged
Conversation
orpuente-MS
requested review from
billti,
idavis,
minestarks and
swernli
as code owners
swernli
approved these changes
Feb 3, 2026
Collaborator
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
Just one minor comment for a couple more test cases, otherwise this change looks ready to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
@NoiseIntrinsic()attribute to Q# and a@qdk.qir.noise_intrinsicattribute to the OpenQASM compiler, which map to the new"qdk_noise"attribute during codegen.run_qirAPI so that it can run noiseless simulations on QIR that has noise intrinsics.