Fix missing freq param in cache update writer locks#2117
Open
Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix missing freq param in cache update writer locks#2117Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Pass freq to C.dpm.get_data_uri() in DiskExpressionCache.update() and DiskDatasetCache.update() to avoid KeyError when non-default frequencies are configured. Fixes microsoft#2012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
freqtoC.dpm.get_data_uri()inDiskExpressionCache.update()(line 594) andDiskDatasetCache.update()(line 961)freq,get_data_uri()falls back toDEFAULT_FREQ, which raisesKeyErrorwhen only non-default frequencies are configuredRoot Cause
Both
update()methods receive afreqparameter but the writer lock callsC.dpm.get_data_uri()without forwarding it. This is inconsistent with all other call sites in the same file which correctly passfreq.Test plan
get_data_uricall sites incache.pypassfreq(lines 324, 549, 727, 737, 778, 783, 1155)Fixes #2012