fix: normalize datetime64 to nanosecond precision in Index for consistent hashing#2120
Open
Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: normalize datetime64 to nanosecond precision in Index for consistent hashing#2120Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…tent hashing numpy.datetime64 values with different precisions (e.g. 'ns' vs 's') compare as equal but produce different hashes, breaking dict lookups and set operations in Index, concat, sum_by_index, and _align_indices. Fixes microsoft#1806
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numpy.datetime64values to nanosecond (ns) precision duringIndex.__init__construction, ensuring consistent hashing across all dict lookups and set operationsKeyErrorwhen multipleIndexobjects with different datetime64 precisions interact inconcat,sum_by_index,__or__, and_align_indicesRoot Cause
numpy.datetime64values with different precisions (e.g.'ns'vs's') compare as equal (==returnsTrue) but produce different hashes. SinceIndexuses adictforindex_mapand several operations useset(), mismatched precisions causeKeyErrorfailures even though the datetime values are logically identical.Fix
A single normalization line in
Index.__init__that converts datetime64 arrays todatetime64[ns]— the standard precision used by pandas. This fixes all downstream operations at the source rather than patching each individually.Test plan
test_datetime64_precision_normalizationtest covering all affected code pathstest_index_data.pytests passFixes #1806