fix concat then filter #397
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 21, 2021 10:17
|
|
you-n-g
reviewed
Apr 22, 2021
| kwargs['col_set'] = ['filter'] | ||
| data_filter = super()._prepare_seg(slc=slc, **kwargs) | ||
| if kwargs.get('data_key') == DataHandlerLP.DK_L: | ||
| col_filter = data_filter['filter']['keep_train'] |
Collaborator
There was a problem hiding this comment.
Please don't hardcode them
| if kwargs.get('data_key') == DataHandlerLP.DK_L: | ||
| col_filter = data_filter['filter']['keep_train'] | ||
| elif kwargs.get('data_key') == DataHandlerLP.DK_I: | ||
| col_filter = data_filter['filter']['keep_test'] |
|
|
||
| # TSDatasetH will retrieve more data for complete | ||
| data = super()._prepare_seg(slice(pad_start, end), **kwargs) | ||
| col_filter = _prepare_col_filter(slice(pad_start, end), **kwargs) |
you-n-g
reviewed
May 23, 2021
| if col_filter[idx2]: | ||
| idx_map[idx] = (i, j) | ||
| idx += 1 | ||
| idx2 += 1 |
| # The index of usable data is between start_idx and end_idx | ||
| self.start_idx, self.end_idx = self.data.index.slice_locs(start=pd.Timestamp(start), end=pd.Timestamp(end)) | ||
| self.idx_df, self.idx_map = self.build_index(self.data) | ||
| if col_filter is None: |
|
|
||
| # TSDatasetH will retrieve more data for complete | ||
| data = super()._prepare_seg(slice(pad_start, end), **kwargs) | ||
| col_filter = _prepare_col_filter(slice(pad_start, end), **kwargs) |
Collaborator
|
Closed due to the same feature merged in #290 |
you-n-g
pushed a commit
to you-n-g/qlib
that referenced
this pull request
Aug 16, 2025
…microsoft#409) * Fixes on kaggle output * feat: add kaggle s3e14 template (microsoft#394) * add s3e14 template * fix CI * Initialisation of a template of competition * add kaggle s3e16 template (microsoft#396) * get kaggle competition scores (microsoft#397) * Adding a new competition s4e6 * feat: s4e5 (microsoft#400) * init for s4e5 * edit s4e5 * ci issue * feat: S4e3 (microsoft#402) * Initialisation of a template of competition * Adding a new competition s4e6 * Competition Initialised * Fixed to make sure that now it runs * Fixing for CI * correct evaluation (microsoft#403) * find rank in leaderboard (microsoft#405) * fix: model templates for KG scenario (microsoft#408) * fix feature selection for some models * feat select template * Updating the prompts for a more powerful model tuning * refine the prompt * fix: template error in s4e6 * feat: show simple execution time in demo (microsoft#410) * show time in kaggle demo * change color * fix a small bug * edit loop.py and proposal * delete useless files * CI issues * ci issue --------- Co-authored-by: XianBW <36835909+XianBW@users.noreply.github.com> Co-authored-by: Haoran Pan <167847254+TPLin22@users.noreply.github.com> Co-authored-by: Way2Learn <118058822+Xisen-Wang@users.noreply.github.com> Co-authored-by: WinstonLiyt <1957922024@qq.com> Co-authored-by: TPLin22 <tplin2@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes