Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Assembly property values set from within response files cannot end with quote marks #679

@cgranade

Description

@cgranade

Describe the bug

When using the --assembly-properties command line argument to qsc.dll from within a response file, assembly property values cannot end with a double-quote character ("").

To Reproduce

Steps to reproduce the behavior:

  1. In a qsc.rsp file, add an argument to the --assembly-properties option that ends with a double-quote character. E.g.:

    --assembly-properties ProcessorArchitecture:Unspecified QsharpOutputType:QsharpLibrary ExecutionTarget:Any DocsPackageId:Microsoft.Quantum.Standard DocsOutputPath:"C:\Users\cgran\source\repos\microsoft\quantumlibraries\Standard\src\docs"
    
  2. Invoke qsc.dll with the given response file.

Expected behavior

The DocsOutputPath assembly property to be set to "C:\Users\cgran\source\repos\microsoft\quantumlibraries\Standard\src\docs". Due to https://github.com/microsoft/qsharp-compiler/blob/feature/docgen/src/QsCompiler/CommandLineTool/Commands/Build.cs#L136, the closing " is stripped by the call to Trim.

System information

  • Beta package version: Microsoft.Quantum.Sdk/0.12.201016171-beta

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions