This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Move Bond Schemas to QIR #1014
Merged
Move Bond Schemas to QIR #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ScottCarda-MS
commented
May 4, 2021
ScottCarda-MS
commented
- Moved the bond schemas for QIR into the QIR Generation Project.
- Removed all dependencies for these bond schemas in the Compiler and Test projects.
- Separated out static functions for name generation of QIR operations to their own static class.
- Added static class EntryPointOperationLoader for loading EntryPointOperation objects from dlls.
…r content and tests.
kuzminrobin
approved these changes
May 4, 2021
Contributor
kuzminrobin
left a comment
kuzminrobin
left a comment
There was a problem hiding this comment.
I'm not that familiar with .cs, I would recommend at least one more approval. Approving.
cesarzc
reviewed
May 4, 2021
cesarzc
reviewed
May 4, 2021
cesarzc
reviewed
May 5, 2021
cesarzc
reviewed
May 5, 2021
cesarzc
reviewed
May 5, 2021
cesarzc
reviewed
May 5, 2021
cesarzc
approved these changes
May 6, 2021
cesarzc
added a commit
that referenced
this pull request
Jul 8, 2021
* Make interfaces public for development. (#944) * Make interface public (#950) * Generate command line arguments string based on model (#965) * Added c++ entrypoint template (#929) Co-authored-by: César Zaragoza Cortés <cesarzc@microsoft.com> Co-authored-by: César Zaragoza Cortés <cesar.zaragoza@outlook.com> * Puzzleshark/entry point driver fixes (#971) * Removed disable warning pragma. (#972) * Merge main into feature branch (#1003) * LoadQirByteCode (#996) * Move Bond Schemas to QIR (#1014) * Microsoft Simulator Library Fix (#1071) Co-authored-by: Alexander Chocron <alchocro@microsoft.com> Co-authored-by: Sam Banning <samcbanning@gmail.com> Co-authored-by: Scott Carda <55811729+ScottCarda-MS@users.noreply.github.com> Co-authored-by: Bettina Heim <beheim@microsoft.com> Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.