This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Doc Comments for Transformations #1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettinaheim
reviewed
Jun 15, 2021
| /// </summary> | ||
| public static class TrimSyntaxTree | ||
| { | ||
| /// <summary> |
Contributor
There was a problem hiding this comment.
It might be worth calling out what happens to types and type constructors. (I think the types may be preserved but the type constructors are subject to the same trimming rules as other callables?)
Contributor
Author
There was a problem hiding this comment.
I was looking for that. I thought we had updated the code to prevent type constructors from being removed at some point. Do you remember?
bettinaheim
approved these changes
Jun 15, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation comments for the Trim Syntax Tree transformation and the Validate Monomorphization transformation.