This repository was archived by the owner on Jan 12, 2024. It is now read-only.
QIR generation bug fixes #1153
Merged
QIR generation bug fixes #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 31, 2021 19:03
cesarzc
reviewed
Sep 22, 2021
cesarzc
reviewed
Sep 22, 2021
cesarzc
reviewed
Sep 22, 2021
src/QsCompiler/QirGeneration/Subtransformations/ExpressionKindTransformation.cs
Outdated
Show resolved
Hide resolved
cesarzc
reviewed
Sep 22, 2021
src/QsCompiler/QirGeneration/Subtransformations/ExpressionKindTransformation.cs
Outdated
Show resolved
Hide resolved
cesarzc
reviewed
Sep 22, 2021
src/QsCompiler/QirGeneration/Subtransformations/ExpressionKindTransformation.cs
Show resolved
Hide resolved
cesarzc
reviewed
Sep 22, 2021
cesarzc
approved these changes
Sep 23, 2021
added 2 commits
September 22, 2021 19:18
swernli
added a commit
that referenced
this pull request
Oct 4, 2021
* QIR generation bug fixes (#1153) * Allow ProjectReference as Target Package (#1166) Previously only a `PackageReference` would be recognized as a target package. This allows `ProjectReference` to be used as a target package, and still enforces that only one such reference exists. * Make signature for slicing compiliant with spec (#1167) * update packages for component governance (#1168) * Q# Command Line Process Multiple Files and Directories (#1156) * Force use of LLVM 11 in build pipeline (#1177) * Formatter - Output to Files (#1165) * Only re-indent if closing brace occurs in indentation region (#1174) * Only re-indent if closing brace occurs in indentation region * Use char.IsWhiteSpace * Blank line Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com> Co-authored-by: Angela Burton <anjbur@users.noreply.github.com> Co-authored-by: Scott Carda <55811729+ScottCarda-MS@users.noreply.github.com> Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1152, #1151, #1086, #1159, #1160, #1161, #1162, #1164, and #1096.
This PR also removes the use of __quantum__rt__pauli_to_string, and adjust the signature of __quantum__rt__array_slice_1d to match the runtime implementation (which deviates from spec - this will be remedied shortly).