This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Sort documentation items when merging TOCs and namespaces.#273
Merged
Sort documentation items when merging TOCs and namespaces.#273
Conversation
bettinaheim
approved these changes
Dec 28, 2019
| /// <param name="ns">The namespace to be represented</param> | ||
| /// <param name="sourceFiles">If specified, only the items in the specified source files are included.</param> | ||
| internal DocNamespace(QsNamespace ns, IEnumerable<string> sourceFiles = null) | ||
| internal DocNamespace(QsNamespace ns, IEnumerable<string>? sourceFiles = null) |
Contributor
There was a problem hiding this comment.
IEnumerables are nullable anyway - why the additional nullable?
Contributor
Author
There was a problem hiding this comment.
I added #nullable enable at the top since YamlDotNet now uses that new C# 8 feature. That makes references non-nullable by default (though violations are warnings rather than errors)
Contributor
Author
|
Thanks for looking over, @bettinaheim! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.