This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fix Unit Test - Apply If One Else Zero#288
Closed
ScottCarda-MS wants to merge 14 commits intofeatures/ClassicallyControlledfrom
Closed
Fix Unit Test - Apply If One Else Zero#288ScottCarda-MS wants to merge 14 commits intofeatures/ClassicallyControlledfrom
ScottCarda-MS wants to merge 14 commits intofeatures/ClassicallyControlledfrom
Conversation
…functor support, and generics support.
…rol tests to their own file.
…but their failures are tracked in the system with tasks.
…lt expression to Zero.
Contributor
Author
|
This PR is being abandoned in favor of PR #289. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relies on PR #287.
Fixes an issue brought to light by the Classical Control unit test #9, where the conversion from an if/else statement to an ApplyIfElse statement assumed the condition compared against a result literal Zero.