This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Updating Sdk readme and adding an example for defining custom compiler extensions#300
Merged
bettinaheim merged 10 commits intomasterfrom Feb 3, 2020
Merged
Updating Sdk readme and adding an example for defining custom compiler extensions#300bettinaheim merged 10 commits intomasterfrom
bettinaheim merged 10 commits intomasterfrom
Conversation
bamarsha
approved these changes
Feb 1, 2020
ScottCarda-MS
approved these changes
Feb 1, 2020
Co-Authored-By: Sarah Marshall <33814365+marshallsa@users.noreply.github.com>
…ns in a referenced .NET Core project
Contributor
Author
|
@ScottCarda-MS, @MarshallSA Thanks for taking a quick look! |
bettinaheim
changed the title
cgranade
approved these changes
Feb 3, 2020
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
I won't claim to know the relevant APIs too well, but this looks really helpful in getting going with rewrite rules! I'm excited to give this a go! ♥
cesarzc
approved these changes
Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mathias ran into an issue where a rewrite step defined in a project reference failed with a FileNotFoundException despite that that dll was present in the project output directory. Updated to section on how to troubleshoot extensions to suggest how that case may be fixed.
I also decided that it would be helpful to have an example for how to define custom compilation steps, and cleaned up and added the demo.
Also, updating the used packages to the latest release.