This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Migrate docgen TOC merging to dictionaries#303
Merged
Conversation
bettinaheim
approved these changes
Feb 3, 2020
Contributor
bettinaheim
left a comment
bettinaheim
left a comment
There was a problem hiding this comment.
I assume you have already used this version to build the docs for our last release?
Contributor
Author
That's correct, the current docs were generated using the code in this PR. |
Contributor
Author
|
Thanks for the review, @bettinaheim! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves TOC merging over to using dictionaries, so as to guarantee that UIDs each have a unique mapping to TOC items.