This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Classically Controlled to Master#310
Merged
ScottCarda-MS merged 66 commits intomasterfrom Feb 12, 2020
Merged
Conversation
…rrently disabled by comments.
…rations. Also added a transformation for reassigning all type param references in the scope to the new local type params of the genrerated operation.
… on a whole callable, and added logic for some special cases where the transformation should not reroute.
…bclass inside the ClassicallyControlledTranformation class.
…ion block hoisting.
…deal with mutables, and change logic to all-or-nothing with if-else conversions.
…eir argument application.
…ol operations. Still needs some work in resolving some ToDo's.
…functor-appropriate ApplyIf operation is used to call them.
…nitTests Classically Controlled Unit Tests
…p-compiler into beheim/branching
Fixed Issues found with Unit Tests.
Updates from master
Removed completed ToDo's
bettinaheim
reviewed
Feb 12, 2020
Contributor
bettinaheim
left a comment
bettinaheim
left a comment
There was a problem hiding this comment.
I've commented on two minor things that should be addressed before merging, but other than that looks good!
…b.com/microsoft/qsharp-compiler into sccarda/ClassicallyControlledToMaster
bettinaheim
reviewed
Feb 12, 2020
bettinaheim
reviewed
Feb 12, 2020
bettinaheim
approved these changes
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the Classically Controlled Rewrite step to the compilation steps. This step resolves if-conditions that are reliant on results from quantum measurements to calls to the interfaces operations, otherwise known as ApplyIf operations. This allows a wider range of code to be consumable by hardware.