This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Transformation API clean-up - part I#319
Merged
bettinaheim merged 97 commits intofeatures/transformationSetupfrom Feb 20, 2020
Merged
Transformation API clean-up - part I#319bettinaheim merged 97 commits intofeatures/transformationSetupfrom
bettinaheim merged 97 commits intofeatures/transformationSetupfrom
Conversation
added 30 commits
February 10, 2020 17:04
…tructor on subtransformations
…check IdentifierReferences transformation!
…oldingOverExpressions
added 14 commits
February 16, 2020 09:36
This reverts commit 38a37dc.
bettinaheim
requested review from
ScottCarda-MS,
bamarsha,
cesarzc and
msoeken
added 6 commits
February 16, 2020 16:29
ScottCarda-MS
approved these changes
Feb 19, 2020
Contributor
ScottCarda-MS
left a comment
ScottCarda-MS
left a comment
There was a problem hiding this comment.
Could you use the TransformationState pattern that is used in C#? I know F# has the capability to do it without, but it would be nice just for consistency.
…mizing transformations
src/QsCompiler/Optimizations/OptimizingTransformations/CallableInlining.fs
Outdated
Show resolved
Hide resolved
bettinaheim
commented
Feb 20, 2020
src/QsCompiler/Optimizations/OptimizingTransformations/CallableInlining.fs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the naming and the handles of the 6 subtransformations.
I migrated all F# transformations, and in particular all transformations in the Optimization project.
Also, I realized that F# seems to fail when accessing overridden handles as part of a constructor (after the initial construction), even though the same works fine when used from within C#. I hence revised that setup.
What I haven't don't yet is making a distinction between the action on a node and the recursion, or and attempt to unify the transformations and walkers (and correspondingly I haven't touched the walkers so far).