This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Addressing Some Special Cases#329
Merged
ScottCarda-MS merged 6 commits intofeatures/ClassicalControlRewritefrom Feb 23, 2020
Merged
Addressing Some Special Cases#329ScottCarda-MS merged 6 commits intofeatures/ClassicalControlRewritefrom
ScottCarda-MS merged 6 commits intofeatures/ClassicalControlRewritefrom
Conversation
Contributor
ScottCarda-MS
commented
Feb 22, 2020
ScottCarda-MS
commented
- Rewrote some of the test to be more streamlined.
- Adjusted the tests for ApplyIfElse to ensure the correct order of type arguments.
- Updated the logic for determining functor support for generated ApplyIf operations.
- Added test to ensure skipping of unnecessary hoisting doesn't prevent necessary hoisting in other blocks of the same if-structure.
…Conditionally logic.
…supported functors of its arguments. Remove some unnecessary logic from the tests and updated the ApplyIfElse tests to check for proper type argument order.
…hem not needing hoisting.
bettinaheim
approved these changes
Feb 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.