This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Apply Conditionally Logic for Classical Control Transformation#330
Merged
ScottCarda-MS merged 15 commits intofeatures/ClassicalControlRewritefrom Feb 28, 2020
Merged
Conversation
…Conditionally logic.
…supported functors of its arguments. Remove some unnecessary logic from the tests and updated the ApplyIfElse tests to check for proper type argument order.
…hem not needing hoisting.
ScottCarda-MS
changed the title
ScottCarda-MS
changed the title
bettinaheim
reviewed
Feb 24, 2020
src/QsCompiler/Transformations/ClassicallyControlledTransformation.cs
Outdated
Show resolved
Hide resolved
src/QsCompiler/Transformations/ClassicallyControlledTransformation.cs
Outdated
Show resolved
Hide resolved
…soft/qsharp-compiler into sccarda/ApplyConditionally
cesarzc
suggested changes
Feb 24, 2020
src/QsCompiler/Transformations/ClassicallyControlledTransformation.cs
Outdated
Show resolved
Hide resolved
src/QsCompiler/Transformations/ClassicallyControlledTransformation.cs
Outdated
Show resolved
Hide resolved
src/QsCompiler/Transformations/ClassicallyControlledTransformation.cs
Outdated
Show resolved
Hide resolved
cesarzc
approved these changes
Feb 25, 2020
Contributor
cesarzc
left a comment
cesarzc
left a comment
There was a problem hiding this comment.
Thanks for incorporating the feedback. I really like the summaries you added! They are very useful to understand the code better.
bettinaheim
approved these changes
Feb 28, 2020
Co-Authored-By: bettinaheim <34236215+bettinaheim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added logic to handle case where two non-literal results are being compared, converting them to use the ApplyConditionally interface operations.